linux-kernel - Re: [PATCH] UIO: only call pgprot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0811050933m13addb7eiddb963bfdf4d7416@mail.gmail.com>
Date:	Wed, 5 Nov 2008 12:33:37 -0500
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Greg KH" <gregkh@...e.de>
Cc:	"Hans J. Koch" <hjk@...utronix.de>,
	"Mike Frysinger" <vapier@...too.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] UIO: only call pgprot_noncached if defined

On Wed, Nov 5, 2008 at 11:33, Greg KH wrote:
> On Wed, Nov 05, 2008 at 12:36:11PM +0100, Hans J. Koch wrote:
>> There seem to be archs that cannot easily implement a sensible
>> pgprot_noncached() function, so we should merge this patch. UIO doesn't
>> compile on these archs right now.
>
> No, we should fix those arches to have that function at least NULLed
> out.  Isn't there only one, Blackfin?  Putting #ifdefs in .c files is
> not something we really want to do if at all possible.

that was my question.  this function isnt documented.  if the hardware
doesnt support it, is the right thing really for the arch to lie to
drivers and not actually give back cached settings even though it
asked for non-cached ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/