linux-kernel - Re: [PATCH 2/2] Block: use round_jiffies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4911144E.3030404@kernel.org>
Date:	Wed, 05 Nov 2008 12:34:38 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Jens Axboe <jens.axboe@...cle.com>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] Block: use round_jiffies_up()

Hello,

Alan Stern wrote:
> @@ -78,13 +78,14 @@ void blk_delete_timer(struct request *re
>  	/*
>  	 * Nothing to detach
>  	 */
> -	if (!q->rq_timed_out_fn || !req->deadline)
> +	if (!req->deadline)
>  		return;
>  
>  	list_del_init(&req->timeout_list);
>  
>  	if (list_empty(&q->timeout_list))
>  		del_timer(&q->timeout);
> +	req->deadline = 0;
>  }

Actually, this can just be

blk_delete_timer()
{
	list_del_init(&req->timeout_list);
	if (list_empty(&q->timeout_list))
		del_timer(&q->timeout);
}

and none of req->deadline trick is necessary.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/