linux-kernel - Re: [PATCH] ftrace: add an fsync tracer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081106072056.GL15731@elte.hu>
Date:	Thu, 6 Nov 2008 08:20:56 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Marcin Slusarz <marcin.slusarz@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ftrace: add an fsync tracer


* Arjan van de Ven <arjan@...radead.org> wrote:

> > > +	buffer = kmalloc(4096, GFP_KERNEL);

> > > +	err = d_path(&file->f_path, buffer, 4096);

hm, magic constants.

> > > +	if (IS_ERR(err))
> > > +		goto out;
> > > +
> > > +	ftrace_printk("Process %s is calling fsync on %s\n",
> > > +			current->comm, err);
> > 
> > err? not buffer?
> 
> correct, not buffer
> 
> it won't work if you use buffer.

please use some other name than 'err' - since "error" is just a 
property of the path string pointer you get back from do_path().

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/