linux-kernel - Re: [patch 2/3] x86: Add smp_mb() before sending INVALIDATE_TLB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081106084331.GY21867@kernel.dk>
Date:	Thu, 6 Nov 2008 09:43:31 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Suresh Siddha <suresh.b.siddha@...el.com>,
	jeremy.fitzhardinge@...rix.com, nickpiggin@...oo.com.au,
	torvalds@...ux-foundation.org, paulmck@...ux.vnet.ibm.com,
	linux-kernel@...r.kernel.org, venkatesh.pallipadi@...el.com
Subject: Re: [patch 2/3] x86: Add smp_mb() before sending INVALIDATE_TLB_VECTOR

On Thu, Nov 06 2008, Ingo Molnar wrote:
> 
> * Suresh Siddha <suresh.b.siddha@...el.com> wrote:
> 
> > On x86, x2apic mode accesses for sending IPI's don't have 
> > serializing semantics. If the IPI receiver refers(in lock-free 
> > fashion) to some memory setup by the sender, the need for smp_mb() 
> > before sending the IPI becomes critical in x2apic mode.
> > 
> > Add the smp_mb() in native_flush_tlb_others() before sending the 
> > IPI.
> > 
> > Signed-off-by: Suresh Siddha <suresh.b.siddha@...el.com>
> 
> applied to tip/x86/urgent, thanks Suresh!
> 
> Jens, you'll send 1/3 and 3/3 to Linus, right?

Yes, it's in for-linus and I'll send the pull request today.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/