linux-kernel - [PATCH] linux-input: TSC-10 DM USB touchscreen driver assume 2-byte response from controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4f20e170811060725v2ae331f9t7b1ba48059f93170@mail.gmail.com>
Date:	Thu, 6 Nov 2008 15:25:40 +0000
From:	"Nuno Lucas" <ntlucas@...il.com>
To:	linux-input@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, "Dmitry Torokhov" <dtor@...l.ru>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: [PATCH] linux-input: TSC-10 DM USB touchscreen driver assume 2-byte response from controller

The usbtouchscreen module implements a driver for the TSC-10 DM USB
touchscreen controllers, but assumes a 2-byte response for the
CMD_RESET and CMD_RATE commands, when they can be only a single byte
when no EEPROM is connected.

The driver worked with an earlier controller revision, but new
revisions of the controller fail.

It seems the problem is that the early controller had the
SEL4/EEPROM-CS pin high, but the new controller has it down, making
the response different.

Without the fix, the controller would answer the single byte 0x06
(ACK), making the init fail with -ENODEV because buf[1] is 0xFF (as
initialized before).

As the single byte is the only thing we need to check it was ok, there
is no need to verify the second byte.

The [0x15 0x01] case is the NAK [0x15] response for when there is no
data in the EEPROM [bit-0 of second byte set], so I let that be, as I
don't have any controller with an EEPROM.

With this patch, both the earlier and latest controller work the same.

Note: This was previously submited as BUG #11961 [1] on the bugzilla
tracker, but rebased to version 2.6.27.4 and with unnecessary comments
and printk's removed.

Signed-off-by: Nuno Lucas <ntlucas@...il.com>

[1] http://bugzilla.kernel.org/show_bug.cgi?id=11961

View attachment "patch-fix_for_some_tsc205_controllers.diff" of type "text/x-patch" (956 bytes)