linux-kernel - Re: [PATCH] [RESEND] documentation: xip documentation update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49131A80.3000402@coritel.it>
Date:	Thu, 06 Nov 2008 17:25:36 +0100
From:	Marco Stornelli <marco.stornelli@...itel.it>
To:	mtk.manpages@...il.com
Cc:	rdunlap@...otime.net, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] documentation: xip documentation update


Michael Kerrisk wrote:
> Marco,
> 
> A few comments below.
> 
> On Thu, Nov 6, 2008 at 10:33 AM, Marco Stornelli
> <marco.stornelli@...itel.it> wrote:
>> From: Marco Stornelli <marco.stornelli@...il.com>
>>
>> xip documentation updated
>> Signed-off-by: Marco Stornelli <marco.stornelli@...il.com>
>> ---
>>
>> --- a/Documentation/filesystems/xip.txt.orig    2008-08-20 20:11:37.000000000 +0200
>> +++ b/Documentation/filesystems/xip.txt 2008-11-06 12:47:48.000000000 +0200
>> @@ -39,10 +39,11 @@ The block device operation is optional,
>>  today:
>>  - dcssblk: s390 dcss block device driver
>>
>> -An address space operation named get_xip_page is used to retrieve reference
>> -to a struct page. To address the target page, a reference to an address_space,
>> -and a sector number is provided. A 3rd argument indicates whether the
> 
>> -function should allocate blocks if needed.
>> +An address space operation named get_xip_mem is used to retrieve reference
> 
> s/reference/a reference/?

Ok, it should actually be "references".

> 
>> +to a page frame number and a kernel address. To obtain these values a reference
>> +to an address_space is provided. This function assigns values to the kmem and
>> +pfn parameters. The 3rd argument indicates whether the function should allocate
> 
> It's a taste thing, but I would write "third" not "3rd".  (I
> appreciate that the existing text already used "3rd", but maybe that
> should be fixed.)

Ok.

> 
>> +blocks if needed.
>>
>>  This address space operation is mutually exclusive with readpage&writepage that
>>  do page cache read/write operations.
> 
> Cheers,
> 
> Michael
> 


I wait for other comments before re-send the patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/