lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081106173224.GA25767@infradead.org>
Date:	Thu, 6 Nov 2008 12:32:24 -0500
From:	Christoph Hellwig <hch@...radead.org>
To:	"J.R. Mauro" <jrm8005@...il.com>
Cc:	Paul Mackerras <paulus@...ba.org>, Greg KH <greg@...ah.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	LKML <linux-kernel@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	"William L. Irwin" <wli@...omorphy.com>, sparclinux@...r.kernel.org
Subject: Re: sparc/staging compile error

On Thu, Nov 06, 2008 at 09:06:36AM -0500, J.R. Mauro wrote:
> static int poch_ioctl(struct inode *inode, struct file *filp,
>                       unsigned int cmd, unsigned long arg)
> {
> /* ---snip---*/
>         case POCH_IOC_SYNC_GROUP_FOR_USER:
>         case POCH_IOC_SYNC_GROUP_FOR_DEVICE:
>                 vms = find_vma(current->mm, arg);
>                 if (!vms)
>                         /* Address not mapped. */
>                         return -EINVAL;
>                 if (vms->vm_file != filp)
>                         /* Address mapped from different device/file. */
>                         return -EINVAL;
> 
>                 flush_cache_range(vms, arg, arg + channel->group_size);

This doesn't look like something a driver should ever do.  Could someone
explain what it's trying to do from a high level point of view?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ