linux-kernel - Re: [PATCH -v2 4/4] AUDIT: emit new record type showing all capset information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Nov 2008 14:03:38 -0500
From:	Eric Paris <eparis@...hat.com>
To:	"Serge E. Hallyn" <serue@...ibm.com>
Cc:	linux-kernel@...r.kernel.org, linux-audit@...hat.com,
	sgrubb@...hat.com, morgan@...nel.org, viro@...IV.linux.org.uk
Subject: Re: [PATCH -v2 4/4] AUDIT: emit new record type showing all capset
 information

On Tue, 2008-11-04 at 10:55 -0600, Serge E. Hallyn wrote:
> Quoting Eric Paris (eparis@...hat.com):
> > diff --git a/kernel/capability.c b/kernel/capability.c
> > index 33e51e7..3d7fc70 100644
> > --- a/kernel/capability.c
> > +++ b/kernel/capability.c
> > @@ -7,6 +7,7 @@
> >   * 30 May 2002:	Cleanup, Robert M. Love <rml@...h9.net>
> >   */
> > 
> > +#include <linux/audit.h>
> >  #include <linux/capability.h>
> >  #include <linux/mm.h>
> >  #include <linux/module.h>
> > @@ -457,6 +458,8 @@ asmlinkage long sys_capset(cap_user_header_t header, const cap_user_data_t data)
> >  		i++;
> >  	}
> > 
> > +	audit_log_capset(pid, &effective, &inheritable, &permitted);
> 
> Shouldn't sys_capset() fail if audit_log_capset() returns -ENOMEM?

yes, I think it should, but look for the next e-mail.....

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/