linux-kernel - Re: next-20081106: today's ftrace episode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49134D8E.1070407@redhat.com>
Date:	Thu, 06 Nov 2008 15:03:26 -0500
From:	Steven Rostedt <srostedt@...hat.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	mingo@...hat.com
Subject: Re: next-20081106: today's ftrace episode

Alexey Dobriyan wrote:
> On m68k-amiga:
>
>   CC      arch/m68k/kernel/asm-offsets.s
> In file included from include/linux/fs.h:287,
>                  from include/linux/ftrace.h:5,		<===
>                  from include/linux/hardirq.h:7,
>                  from include2/asm/system.h:69,
>                  from include/linux/list.h:7,		<===
>                  from include/linux/preempt.h:11,
>                  from include/linux/spinlock.h:50,
>                  from include/linux/seqlock.h:29,
>                  from include/linux/time.h:8,
>                  from include/linux/timex.h:57,
>                  from include/linux/sched.h:54,
>                  from arch/m68k/kernel/asm-offsets.c:12:
> include/linux/wait.h:37: error: field 'task_list' has incomplete type
> 	...
>
> commit 7e5e26a3d8ac4bcadb380073dc9604c07a9a6198 aka "trace: fix hardirq header for non ftrace archs"
>
>
>   
We only need to include the ftrace.h to declare the ftrace_nmi_enter and 
exit.

I could separate that out into its own "ftrace_irq.h" file, that 
hardirq.h can include. That should fix it.

basically all that would be needed in that file is this:

#ifdef CONFIG_DYNAMIC_FTRACE
    extern void ftrace_nmi_enter(void);
    extern void ftrace_nmi_exit(void);
#else
    static inline void ftrace_nmi_enter(void) { }
    static inline void ftrace_nmi_exit(void) { }
#endif /* CONFIG_DYNAMIC_FTRACE */

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/