linux-kernel - Re: [PATCH] x86: call machine_shutdown and stop all CPUs in native_machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081106204351.GG3578@elte.hu>
Date:	Thu, 6 Nov 2008 21:43:51 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Ivan Vecera <ivecera@...hat.com>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, nhorman@...hat.com, jmarchan@...hat.com
Subject: Re: [PATCH] x86: call machine_shutdown and stop all CPUs in
	native_machine_halt


* Ivan Vecera <ivecera@...hat.com> wrote:

> Ingo Molnar wrote:
> > the code in arch/x86/kernel/smp.c::stop_this_cpu() is very similar to 
> > this and could be shared. You could move the stop_this_cpu() function to 
> > arch/x86/kernel/process.c (out of smp.c), so that it can be used by 
> > reboot.c.
> > 
> Yes, this make sense. Here is the patch.

looks good. One small detail:

> +#ifdef CONFIG_X86_LOCAL_APIC
> +	disable_local_APIC();
> +#endif

could you please avoid this #ifdef by putting an inline void function 
for disable_local_APIC() into arch/x86/include/asm/apic.h for the 
!CONFIG_X86_LOCAL_APIC case?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/