linux-kernel - Re: leds-hp-disk vs lis3lv02d

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49136561.1050907@tremplin-utc.net>
Date:	Thu, 06 Nov 2008 22:45:05 +0100
From:	Éric Piel <Eric.Piel@...mplin-utc.net>
To:	Pavel Machek <pavel@...e.cz>, Andrew Morton <akpm@...l.org>
Cc:	Thomas Renninger <trenn@...e.de>, burman.yan@...il.com,
	rpurdie@...ys.net, LKML <linux-kernel@...r.kernel.org>,
	Len Brown <len.brown@...el.com>,
	Kay Sievers <kasievers@...e.de>, hmh@....eng.br
Subject: Re: leds-hp-disk vs lis3lv02d

Pavel Machek schreef:
>>> OTOH  it should 
>>> not block merge; both drivers still work and are useful.
>> But for long-term the HPQ0004 specific things in the lids3v driver should get 
>> merged with your HP leds driver also registering for HPQ0004 and the lids3v 
>> specific things should get a separate driver which HPQ0004 driver makes use 
>> of?
>> So in the end also for the HPQ0004 device only one driver should register for?
> 
> Yep... and this is the step in that direction. Relative to my previous
> patch...
> 
> Later led stuff will get merged to hp_accel.c...
Hi Pavel,
Just to say I like this approach. It should be completely compatible 
with the idea of allowing different buses (SPI and I²C) as well. Of 
course, I wish it could be possible to have the led and accelerometer 
drivers separated because they have no common point but the fact that 
they are advertised by the same PNP ID. But I can deal with that.

Andrew, is there anything preventing the merge of the lis3lv02d driver 
from your tree to Linus' one? I think it's still worth to integrate it 
as is, and later on this refactoring can take place.

See you,
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/