linux-kernel - Re: [PATCH 4/4] ALSA: cs5535audio: OLPC Analog Input and MIC Bias support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45a44e480811051622g3b81ad71tad9ca5a341fedbcc@mail.gmail.com>
Date:	Thu, 6 Nov 2008 08:22:30 +0800
From:	"Jaya Kumar" <jayakumar.alsa@...il.com>
To:	"Andres Salomon" <dilinger@...ued.net>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 4/4] ALSA: cs5535audio: OLPC Analog Input and MIC Bias support

On Thu, Nov 6, 2008 at 6:31 AM, Andres Salomon <dilinger@...ued.net> wrote:
>
> This adds support for the special cs5535audio features that OLPC XO-1s have.
> They support switching between analog and DC recording, and the MIC requires
> toggling V_REFOUT (which this patch renames to MIC Bias) to operate.  There's
> also an EAPD tweak which is necessary for B3 and newer machines.
>
> All of this is enabled by CONFIG_OLPC (and CONFIG_SND_CS5535AUDIO, obviously).
>
> Signed-off-by: Andres Salomon <dilinger@...ian.org>


Andres,

Looks okay. But can you send this patch split into 2 patches? One, the
original cs5535audio_olpc.c that I posted and your changes to it since
then. That'll make it easier for me to review.

Thanks,
jaya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/