linux-kernel - Re: [PATCH 1/1] edac x38: new MC driver module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081106231102.aab83cd4.akpm@linux-foundation.org>
Date:	Thu, 6 Nov 2008 23:11:02 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Hitoshi Mitake <mitake@...stcom.com>
Cc:	Doug Thompson <norsk5@...oo.com>, dougthompson@...ssion.com,
	linux-kernel@...r.kernel.org, ktaka@...stcom.com
Subject: Re: [PATCH 1/1] edac x38: new MC driver module

On Fri, 7 Nov 2008 15:38:24 +0000 Hitoshi Mitake <mitake@...stcom.com> wrote:

> 
> This patch makes x38_edac.c to use kernel's
> readq() function when it is compiled for x86_64.
> 
> Signed-off-by: Hitoshi Mitake <mitake@...stcom.com>
> Signed-off-by: Doug Thompson <dougthompson@...ssion.com>
> ---
> 
> Index: linux-2.6.28-rc3-git2/drivers/edac/Kconfig
> ===================================================================
> --- linux-2.6.28-rc3-git2.orig/drivers/edac/Kconfig	2008-11-07 11:27:05.000000000 +0000
> +++ linux-2.6.28-rc3-git2/drivers/edac/Kconfig	2008-11-07 11:27:14.000000000 +0000
> @@ -104,7 +104,7 @@
>  
>  config EDAC_X38
>  	tristate "Intel X38"
> -	depends on EDAC_MM_EDAC && PCI && X86
> +	depends on EDAC_MM_EDAC && PCI && (X86 || X86_64)

CONFIG_X86 is true for both CONFIG_X86_32=y amek CONFIG_X86_64=y, so
this change isn't needed.  I'll fix that up.

> --- linux-2.6.28-rc3-git2.orig/drivers/edac/x38_edac.c	2008-11-07 11:27:06.000000000 +0000
> +++ linux-2.6.28-rc3-git2/drivers/edac/x38_edac.c	2008-11-07 11:27:29.000000000 +0000
> @@ -162,10 +162,12 @@
>  			 X38_ERRSTS_BITS);
>  }
>  
> -static u64 x38_readq(const void __iomem *addr)
> +#ifndef CONFIG_X86_64
> +static u64 readq(const void __iomem *addr)

hm, it'd be nice if there was some more general way of determining
whether the architecture provides readq/writeq.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/