linux-kernel - Re: [alsa-devel] [PATCH] ALSA: have snd_BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk5bgqa61.wl%tiwai@suse.de>
Date:	Fri, 07 Nov 2008 08:15:18 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Mike Frysinger" <vapier.adi@...il.com>
Cc:	alsa-devel@...a-project.org, Mike Frysinger <vapier@...too.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ALSA: have snd_BUG_ON() always refer to	arguments

At Fri, 7 Nov 2008 02:09:04 -0500,
Mike Frysinger wrote:
> 
> On Fri, Nov 7, 2008 at 01:22, Takashi Iwai wrote:
> > At Thu,  6 Nov 2008 21:05:21 -0500,
> > Mike Frysinger wrote:
> >> The snd_BUG_ON() macro should always expand its argument even if we're
> >> forcing it to false.  This kills off unused warnings that did not exist
> >> before the snd_assert() -> snd_BUG_ON() conversion.
> >
> > Andrew already change this differently.  Check with the latest version.
> 
> what are you defining as "latest version" ?  i'm looking in torvalds
> linux-2.6.git.

git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git

> > And which warning did you get actually?
> 
> a few codecs define local vars which only get used in snd_BUG_ON() ...
> so if snd_BUG_ON() doesnt utilize cond, gcc whines that the var is
> unused.

I know it.  But I thought all these were removed in the actual codes.
I'd like to see the real warning messages.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/