linux-kernel - Re: [patch] add /proc/pid/stack to dump task's stack trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081107092902.GB7787@elte.hu>
Date:	Fri, 7 Nov 2008 10:29:02 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Alexey Dobriyan <adobriyan@...il.com>,
	Ken Chen <kenchen@...gle.com>, linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [patch] add /proc/pid/stack to dump task's stack trace


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Fri, 7 Nov 2008 10:03:04 +0100 Ingo Molnar <mingo@...e.hu> wrote:
> 
> > task running on this CPU:
> > 
> >  # cat /proc/self/stack
> >  [<ffffffff80216f79>] save_stack_trace_tsk+0x26/0x44
> >  [<ffffffff802f59a5>] proc_pid_stack+0x6e/0xd3
> >  [<ffffffff802f6da3>] proc_info_read+0x68/0xba
> >  [<ffffffff802b2f17>] vfs_read+0xa9/0xe3
> >  [<ffffffff802b301f>] sys_read+0x4c/0x73
> >  [<ffffffff8020c23b>] system_call_fastpath+0x16/0x1b
> >  [<ffffffffffffffff>] 0xffffffffffffffff
> 
> So we provide a means by which process A can sample process B's 
> instruction pointer?  Even if it's in random.c or crypto code?  
> There's a little project for someone.

yes - like "echo p > /proc/sysrq-trigger" and sysrq-t. Although unlike 
sysrq-p, the IP itself isnt printed, just the stack trace - but 
there's indeed a correlation.

> I guess the 0400 mode on that file will suffice...

correct, 0400 is used already in the present patch:

 phoenix:~> cat /proc/1/stack
 cat: /proc/1/stack: Permission denied

but that is _not_ enough, it should be narrowed even more, to the 
boundaries that i pointed out in my first review feedback mail, and 
which is not implemented yet:

 1) only root should be allowed to do this - i.e. file needs to be 
    root-owned.

 2) there also needs to be a .config entry for folks to be able to
    turn it off altogether - just like folks can turn off sysrq-t 
    dumping via the .config.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/