linux-kernel - Re: [RFC PATCH] Check if the Hangcheck-timer TSC source is stable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081107092314.GI15220@mail.oracle.com>
Date:	Fri, 7 Nov 2008 01:23:14 -0800
From:	Joel Becker <Joel.Becker@...cle.com>
To:	Michael Trimarchi <trimarchimichael@...oo.it>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] Check if the Hangcheck-timer TSC source is stable

On Thu, Nov 06, 2008 at 11:37:28PM +0100, Michael Trimarchi wrote:
> Check if the TSC source is stable otherwise fail registration.

	Good idea.

> @@ -151,8 +155,10 @@ static void hangcheck_fire(unsigned long data)
>  
>  	if (cur_tsc > hangcheck_tsc)
>  		tsc_diff = cur_tsc - hangcheck_tsc;
> -	else
> -		tsc_diff = (cur_tsc + (~0ULL - hangcheck_tsc)); /* or something */
> +	else {
> +		/* or samenthing */
> +		tsc_diff = (cur_tsc + (~0ULL - hangcheck_tsc));
> +	}

	This hunk isn't any good.  The comment spelling is messed up,
and really you can just remove the "or something".

Joel

-- 

"There is no sincerer love than the love of food."  
         - George Bernard Shaw 

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@...cle.com
Phone: (650) 506-8127
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/