linux-kernel - Re: [RFC][PATCH] mm: the page of MIGRATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081107200251.15e9851a.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Fri, 7 Nov 2008 20:02:51 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Mel Gorman <mel@....ul.ie>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>
Subject: Re: [RFC][PATCH] mm: the page of MIGRATE_RESERVE don't insert into
 pcp

On Fri, 7 Nov 2008 10:42:42 +0000
Mel Gorman <mel@....ul.ie> wrote:

> On Fri, Nov 07, 2008 at 10:42:24AM +0900, KAMEZAWA Hiroyuki wrote:
> > On Thu, 6 Nov 2008 16:46:45 +0000
> > Mel Gorman <mel@....ul.ie> wrote:
> > > > otherwise, the system have unnecessary memory starvation risk
> > > > because other cpu can't use this emergency pages.
> > > > 
> > > > 
> > > > 
> > > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> > > > CC: Mel Gorman <mel@....ul.ie>
> > > > CC: Christoph Lameter <cl@...ux-foundation.org>
> > > > 
> > > 
> > > This patch seems functionally sound but as Christoph points out, this
> > > adds another branch to the fast path. Now, I ran some tests and those that
> > > completed didn't show any problems but adding branches in the fast path can
> > > eventually lead to hard-to-detect performance problems.
> > > 
> > dividing pcp-list into MIGRATE_TYPES is bad ?
> 
> I do not understand what your question is.
> 
Hmm. like this.

	 pcp = &zone_pcp(zone, get_cpu())->pcp[migrate_type];

	
Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/