linux-kernel - Re: [PATCH] ftrace: Allow section alignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0811070901240.23073@gandalf.stny.rr.com>
Date:	Fri, 7 Nov 2008 09:04:03 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Matt Fleming <mjf@...bsd.org>
cc:	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>, mingo@...e.hu
Subject: Re: [PATCH] ftrace: Allow section alignment


On Fri, 7 Nov 2008, Matt Fleming wrote:
> 
> I've tried to explain the bug better in the attached patch. The issue
> is not that there were gaps in __mcount_loc, rather that the addresses
> in __mcount_loc were not aligned on a 4-byte boundary by the
> assembler. Unaligned accesses are not supported by our architecture
> and an alignment of 1-byte will likely lead to performance loss on
> architectures that do support them.

This is what I was looking for ;-)

Yes, I was just telling Peter on IRC, that this might just be an 
architecture request. Which I find as a legitimate reason. But because 
there was no mention of that in the change log, I would have to NACK it.


Ingo,

I'll pull this in my tree and test it first. Then I'll pass it off to you.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/