linux-kernel - RE: [E1000-devel] [PATCH] igb: Reinitialize tx/rx ring count on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <80769D7B14936844A23C0C43D9FBCF0F23825DD9@orsmsx501.amr.corp.intel.com>
Date:	Fri, 7 Nov 2008 14:54:55 -0800
From:	"Duyck, Alexander H" <alexander.h.duyck@...el.com>
To:	"Darrick J. Wong" <djwong@...ibm.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
	"Allan, Bruce W" <bruce.w.allan@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
	"Ronciak, John" <john.ronciak@...el.com>
CC:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [E1000-devel] [PATCH] igb: Reinitialize tx/rx ring count on
 resume

Darrick J. Wong wrote:
> When suspending the device, adapter->[tr]x_ring structures are freed.
> Upon resume, these two pointers are reallocated but
> adapter->[tr]x_ring->count is not set to any value.  This causes
> igb_setup_tx_resources to fail on zero-sized buffers and thus the NIC
> doesn't come back up. 

This patch is a good start, but it ends up resetting the ring sizes on a suspend/resume which we really shouldn't be doing.  I will see about pushing a patch with the ring sizes moved up into the adapter struct.  This should help to resolve the issue and maintain the ring count through suspend/resume.

Thanks,

Alex--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/