[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20081107.131949.106618398.taka@valinux.co.jp>
Date: Fri, 07 Nov 2008 13:19:49 +0900 (JST)
From: Hirokazu Takahashi <taka@...inux.co.jp>
To: kamezawa.hiroyu@...fujitsu.com
Cc: vgoyal@...hat.com, linux-kernel@...r.kernel.org,
containers@...ts.linux-foundation.org,
virtualization@...ts.linux-foundation.org, jens.axboe@...cle.com,
ryov@...inux.co.jp, righi.andrea@...il.com, s-uchida@...jp.nec.com,
riel@...hat.com, fernando@....ntt.co.jp, jmoyer@...hat.com,
menage@...gle.com, ngupta@...gle.com, akpm@...ux-foundation.org,
balbir@...ux.vnet.ibm.com
Subject: Re: [patch 2/4] io controller: biocgroup implementation
Hi,
I'm going to release a new version of bio_cgroup soon, which doesn't
have "struct list_head blist" anymore and whose overhead is minimized.
> > o biocgroup functionality.
> > o Implemented new controller "bio"
> > o Most of it picked from dm-ioband biocgroup implementation patches.
> >
> page_cgroup implementation is changed and most of this patch needs rework.
> please see the latest one. (I think most of new characteristics are useful
> for you.)
>
> One comment from me is
> ==
> > +struct page_cgroup {
> > + struct list_head lru; /* per cgroup LRU list */
> > + struct page *page;
> > + struct mem_cgroup *mem_cgroup;
> > + int flags;
> > +#ifdef CONFIG_CGROUP_BIO
> > + struct list_head blist; /* for bio_cgroup page list */
> > + struct bio_cgroup *bio_cgroup;
> > +#endif
> > +};
> ==
>
> this blist is too bad. please keep this object small...
>
> Maybe dm-ioband people will post his own new one. just making use of it is an idea.
>
> Thanks,
> -Kame
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists