[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081108120601.GF8354@elte.hu>
Date: Sat, 8 Nov 2008 13:06:01 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Alexey Dobriyan <adobriyan@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Ken Chen <kenchen@...gle.com>, linux-kernel@...r.kernel.org,
Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [patch] add /proc/pid/stack to dump task's stack trace
* Alexey Dobriyan <adobriyan@...il.com> wrote:
> > 1) only root should be allowed to do this - i.e. file needs to be
> > root-owned.
> >
> > 2) there also needs to be a .config entry for folks to be able to
> > turn it off altogether - just like folks can turn off sysrq-t
> > dumping via the .config.
>
> In the name of everything holy, don't add another config option.
> It's a _tiny_ piece of code and you have select STACKTRACE via fault
> injection, latencytop or lockdep before that.
We could make it depend on DEBUG_KERNEL or so, and always select
STACKTRACE infrastructure when DEBUG_KERNEL is enabled? There's no
reason not to get high quality backtraces via /proc when one debugs
the kernel.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists