linux-kernel - Re: [PATCH -next] Hibernate: Do not oops on resume if image data are incorrect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20081108130946.GC21405@elf.ucw.cz>
Date:	Sat, 8 Nov 2008 14:09:46 +0100
From:	Pavel Machek <pavel@...e.cz>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Len Brown <lenb@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>
Subject: Re: [PATCH -next] Hibernate: Do not oops on resume if image data
	are incorrect

On Sat 2008-11-08 13:57:42, Rafael J. Wysocki wrote:
> Hi Len,
> 
> Please add this patch to the suspend branch.
> 
> Thanks,
> Rafael
> 
> 
> ---
> From: Rafael J. Wysocki <rjw@...k.pl>
> Subject: Hibernate: Do not oops on resume if image data are incorrect
> 
> During resume from hibernation using the userland interface image
> data are being passed from the used space process to the kernel.
> These data need not be valid, but currently the kernel sometimes
> oopses if it gets invalid image data, which is wrong.  Make the
> kernel return error codes to the user space in such cases.

(Note that userspace will still be able to make it crash / execute
arbitrary code later in the game, by supplying carefully damaged
image. But that's okay and that will always be the case.)

> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> Cc: Pavel Machek <pavel@...e.cz>

Looks okay to me.

Acked-by: Pavel Machek <pavel@...e.cz>

...and thanks :-).
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/