lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 9 Nov 2008 09:14:27 -0800 From: Arjan van de Ven <arjan@...radead.org> To: Julia Lawall <julia@...u.dk> Cc: mchehab@...radead.org, v4l-dvb-maintainer@...uxtv.org, video4linux-list@...hat.com, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH 3/8] drivers/media: use ARRAY_SIZE On Sun, 9 Nov 2008 17:55:03 +0100 (CET) Julia Lawall <julia@...u.dk> wrote: > From: Julia Lawall <julia@...u.dk> > > ARRAY_SIZE is more concise to use when the size of an array is > divided by the size of its type or the size of its first element. Hi, looking at your patch, I don't think I agree it's just blindly the right thing to do. > - *count = sizeof(RegAddr) / sizeof(u8); > + *count = ARRAY_SIZE(RegAddr); really. ARRAY_SIZE doesn't appear to be an improvement here.. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists