linux-kernel - [PATCH] proc: remove useless WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 9 Nov 2008 23:19:55 +0300
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	mingo@...e.hu
Subject: [PATCH] proc: remove useless WARN_ONs

[added to proc.git]

commit 9f5560c4df483908659fca33e7fa768832f933b2
Author: Alexey Dobriyan <adobriyan@...il.com>
Date:   Sun Nov 9 23:12:18 2008 +0300

    proc: remove useless WARN_ONs
    
    NULL "struct inode *" means VFS passed NULL inode to ->open.
    
    Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 486cf3f..4a1c578 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1186,8 +1186,6 @@ static int sched_show(struct seq_file *m, void *v)
 	struct inode *inode = m->private;
 	struct task_struct *p;
 
-	WARN_ON(!inode);
-
 	p = get_proc_task(inode);
 	if (!p)
 		return -ESRCH;
@@ -1205,8 +1203,6 @@ sched_write(struct file *file, const char __user *buf,
 	struct inode *inode = file->f_path.dentry->d_inode;
 	struct task_struct *p;
 
-	WARN_ON(!inode);
-
 	p = get_proc_task(inode);
 	if (!p)
 		return -ESRCH;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/