linux-kernel - Re: [PATCH 10/10] xtensa: use the new byteorder headers - Merged with your previous xtensa-next and will remerge shortly.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49165F4A.4070905@tensilica.com>
Date:	Sat, 08 Nov 2008 19:55:54 -0800
From:	Piet Delaney <piet.delaney@...silica.com>
To:	Harvey Harrison <harvey.harrison@...il.com>
CC:	Chris Zankel <chris@...kel.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Marc Gauthier <marc@...silica.com>,
	Joe Taylor <joetayloremail@...il.com>,
	linux-xtensa@...ux-xtensa.org, Chuck Lever <chuck.lever@...cle.com>
Subject: Re: [PATCH 10/10] xtensa: use the new byteorder headers - Merged
 with your previous xtensa-next and will remerge shortly.

Harvey Harrison wrote:
> On Fri, 2008-11-07 at 19:00 -0800, Piet Delaney wrote:
>> Hi Chris:
>>
>>    I've merged your recent xtensa-next with our 2.6.24-smp repo.
>> It seems to work fine and I'm in the process of cleaning it
>> up a bit and adding preliminary XTENSA kgdb support.
> 
> 2.6.24?  In that case you probably don't have include/linux/byteorder.h,
> or include/linux/swab.h which would explain your byteorder problems.
> 
> Or is that a typo in the version numbers?

I was on 2.6.24 and didn't have a problem compiling the kernel -O0 other
than a minor tweak in slab.c. Now in 2.6.27-rc3 I get a compile problem
with rpcb_clnt.c at lines 122, 123, and 129:

    /export/src/xtensa-next/net/sunrpc/rpcb_clnt.c:129: error: (near initialization for 'rpcb_in6addr_loopback.sin6_port')


> 
> You should be able to just pull those two headers from Linus' tree
> and drop them in, there is no dependencies other than those two
> headers.

byteorder.h was already in sync with linus's tree and I updated swab.c
as it had a few changes. Unfortunately the problem persist. I think the
problem is likely in changes made to rpcb_clnt.c since 2.6.24.

> 
> If it is some other problem, let me know and I'll look into it.

You can likely reproduce it by configuring NFS and compiling -O0.

-piet

> 
> Harvey
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/