linux-kernel - Re: [RFC-PATCH] x86: really use __builtin_memcmp on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1226335996.5478.41.camel@brick>
Date:	Mon, 10 Nov 2008 08:53:16 -0800
From:	Harvey Harrison <harvey.harrison@...il.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC-PATCH] x86: really use __builtin_memcmp on x86_32

On Mon, 2008-11-10 at 09:05 +0100, Ingo Molnar wrote:
> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > * Harvey Harrison <harvey.harrison@...il.com> wrote:
> > 
> > > Impact: prevent generic code from overriding __builtin_memcmp
> > > 
> > > lib/string.c was using a generic implementation of memcmp
> > > because __HAVE_ARCH_MEMCMP was not defined and it was then doing
> > > #undef memcmp and defining a generic version.
> > > 
> > > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> > > ---
> > >  arch/x86/include/asm/string_32.h |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > > +#define __HAVE_ARCH_MEMCMP
> > >  #define memcmp __builtin_memcmp
> > >  
> > >  #define __HAVE_ARCH_MEMCHR
> 
> doesnt work that well:
> 
>  arch/x86/kernel/built-in.o: In function `efi_guidcmp':
>  efi.c:(.text+0x108b2): undefined reference to `memcmp'
>  arch/x86/kernel/built-in.o: In function `smp_check_mpc':
>  mpparse.c:(.init.text+0x4ec6): undefined reference to `memcmp'
>  arch/x86/kernel/built-in.o: In function `powernowk8_cpu_init':
> 
> with the attached config.
> 

Just let this one go to the bitbucket.

Harvey


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/