linux-kernel - Re: [PATCH][RESEND] C99 initializers for DEFINE_RATELIMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0811100932500.3468@nehalem.linux-foundation.org>
Date:	Mon, 10 Nov 2008 09:34:00 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	Bart Van Assche <bart.vanassche@...il.com>,
	Dave Young <hidave.darkstar@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH][RESEND] C99 initializers for DEFINE_RATELIMIT_STATE()



On Mon, 10 Nov 2008, Andrew Morton wrote:
> 
> I already have a patch queued which does this
> (linux-ratelimith-fixed-missing-initializer-warning.patch).  I sent it
> to Linus on October 29 and he did not apply it, so I parked it for 2.6.29.

I just don't see the point of the patch at all. It doesn't fix anything, 
and it just makes the code bigger and uglier. We have tons of other 
simple initializers that aren't C99, and we're not going to convert them 
either. 

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/