linux-kernel - Re: [RFC-PATCH] x86: really use __builtin_memcmp on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081110074536.GB2093@elte.hu>
Date:	Mon, 10 Nov 2008 08:45:37 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC-PATCH] x86: really use __builtin_memcmp on x86_32


* Harvey Harrison <harvey.harrison@...il.com> wrote:

> Impact: prevent generic code from overriding __builtin_memcmp
> 
> lib/string.c was using a generic implementation of memcmp
> because __HAVE_ARCH_MEMCMP was not defined and it was then doing
> #undef memcmp and defining a generic version.
> 
> Signed-off-by: Harvey Harrison <harvey.harrison@...il.com>
> ---
>  arch/x86/include/asm/string_32.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

> +#define __HAVE_ARCH_MEMCMP
>  #define memcmp __builtin_memcmp
>  
>  #define __HAVE_ARCH_MEMCHR

on a quick look, since x86 sets __HAVE_ARCH_STRSTR, nothing in 
lib/string.c would actually use this generic (and slower) memcmp 
implementation, correct? So there should be no impact to object code, 
it's a cleanup - right?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/