[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 11 Nov 2008 16:04:36 -0500 (EST)
From: Steven Rostedt <rostedt@...dmis.org>
To: Andrew Morton <akpm@...ux-foundation.org>
cc: linux-kernel@...r.kernel.org, mingo@...e.hu, tglx@...utronix.de,
torvalds@...ux-foundation.org, sfr@...b.auug.org.au,
linux-next@...r.kernel.org, srostedt@...hat.com
Subject: Re: [PATCH 1/1] ring-buffer: buffer record on/off switch
On Tue, 11 Nov 2008, Andrew Morton wrote:
> On Tue, 11 Nov 2008 15:06:02 -0500
> Steven Rostedt <rostedt@...dmis.org> wrote:
>
> > +static struct file_operations rb_simple_fops = {
>
> should be const...
>
> Probably it isn't worth fixing. Someone(tm) should do period sweeps -
> 10% of our file_operationses aren't const.
Thanks, I never really thought about it.
I'll add to my todo list to send out a patch that cleans all of this up. I
think I'm guilty at doing this in more than one place.
-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists