linux-kernel - Re: [PATCH 3/4] add ksm kernel shared memory driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Nov 2008 15:25:27 -0700
From:	Jonathan Corbet <corbet@....net>
To:	Izik Eidus <ieidus@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	kvm@...r.kernel.org, aarcange@...hat.com, chrisw@...hat.com,
	avi@...hat.com
Subject: Re: [PATCH 3/4] add ksm kernel shared memory driver

On Wed, 12 Nov 2008 00:17:39 +0200
Izik Eidus <ieidus@...hat.com> wrote:

> >> +static int ksm_dev_open(struct inode *inode, struct file *filp)
> >> +{
> >> +	try_module_get(THIS_MODULE);
> >> +	return 0;
> >> +}
> >> +
> >> +static int ksm_dev_release(struct inode *inode, struct file *filp)
> >> +{
> >> +	module_put(THIS_MODULE);
> >> +	return 0;
> >> +}
> >> +
> >> +static struct file_operations ksm_chardev_ops = {
> >> +	.open           = ksm_dev_open,
> >> +	.release        = ksm_dev_release,
> >> +	.unlocked_ioctl = ksm_dev_ioctl,
> >> +	.compat_ioctl   = ksm_dev_ioctl,
> >> +};
> >>       
> >
> > Why do you roll your own module reference counting?  Is there a
> > reason you don't just set .owner and let the VFS handle it?
> >     
> 
> Yes, I am taking get_task_mm() if the module will be removed before i 
> free the mms, things will go wrong

But...if you set .owner, the VFS will do the try_module_get() *before*
calling into your module (as an added bonus, it will actually check the
return value too).  All you've succeeded in doing here is adding a
microscopic race to the module reference counting; otherwise the end
result is the same.

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/