linux-kernel - Re: [PATCH 2/4] Add replace_page(), change the mapping of pte from one page into another

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <491AAA84.5040801@redhat.com>
Date:	Wed, 12 Nov 2008 12:05:56 +0200
From:	Avi Kivity <avi@...hat.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
CC:	Andrea Arcangeli <aarcange@...hat.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Izik Eidus <ieidus@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	kvm@...r.kernel.org, chrisw@...hat.com, izike@...ranet.com
Subject: Re: [PATCH 2/4] Add replace_page(), change the mapping of pte from
 one page into another

KAMEZAWA Hiroyuki wrote:
> Can I make a question ? (I'm working for memory cgroup.)
>
> Now, we do charge to anonymous page when
>   - charge(+1) when it's mapped firstly (mapcount 0->1)
>   - uncharge(-1) it's fully unmapped (mapcount 1->0) vir page_remove_rmap().
>
> My quesion is
>  - PageKSM pages are not necessary to be tracked by memory cgroup ?
>  - Can we know that "the page is just replaced and we don't necessary to do
>    charge/uncharge".
>  - annonymous page from KSM is worth to be tracked by memory cgroup ?
>    (IOW, it's on LRU and can be swapped-out ?)
>   

My feeling is that shared pages should be accounted as if they were not 
shared; that is, a share page should be accounted for each process that 
shares it.  Perhaps sharing within a cgroup should be counted as 1 page 
for all the ptes pointing to it.


-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/