linux-kernel - Re: [PATCH 2/2] x86: ia32_signal: remove unnecessary padding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878wrpdrwq.fsf@basil.nowhere.org>
Date:	Wed, 12 Nov 2008 13:56:21 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] x86: ia32_signal: remove unnecessary padding

Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> writes:

> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>
> Impact: cleanup

Actually it's not a cleanup.

> Remove unnecessary paddings, this saves 4 bytes.

This might actually break code. The code is not actually used,
but only kept around because some old gdb versions used this
code as a marker for detecting signals.

I don't know if they require the padding or not, but it seems
somewhat risky to change a legacy marker like this.

-Andi

-- 
ak@...ux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/