linux-kernel - Re: [PATCH] ttusb-budget: make it depend on PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <874p2ddr72.fsf@basil.nowhere.org>
Date:	Wed, 12 Nov 2008 14:11:45 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Mike Frysinger <vapier@...too.org>, v4l-dvb-maintainer@...uxtv.org,
	linux-dvb@...uxtv.org, Holger Waechtler <holger@...vergence.de>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ttusb-budget: make it depend on PCI

Arnd Bergmann <arnd@...db.de> writes:

> On Wednesday 12 November 2008, Mike Frysinger wrote:
>> From: 
>> Mike Frysinger <vapier@...too.org>
>>   To: 
>> v4l-dvb-maintainer@...uxtv.org, linux-dvb@...uxtv.org, Holger Waechtler <holger@...vergence.de>
>>   CC: 
>> Mauro Carvalho Chehab <mchehab@...radead.org>, linux-kernel@...r.kernel.org
>>   Date: 
>> Today 13:00:18
>>    
>> Since dvb-ttusb-budget.c relies on pci_alloc_consistent and
>> pci_free_consistent, make it depend on PCI in Kconfig.
>> 
>> Signed-off-by: Mike Frysinger <vapier@...too.org>
>
> Shouldn't you just convert it (trivially) to dma_alloc_coherent and
> dma_alloc_coherent?

Unless it really needs to use the 16MB DMA zone (which I doubt
especially for USB devices) then it should not call either with a NULL
device argument.

-Andi

-- 
ak@...ux.intel.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/