linux-kernel - Re: [PATCH] ttusb-budget: make it depend on PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200811121447.00808.arnd@arndb.de>
Date:	Wed, 12 Nov 2008 14:46:59 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Mike Frysinger <vapier@...too.org>, v4l-dvb-maintainer@...uxtv.org,
	linux-dvb@...uxtv.org, Holger Waechtler <holger@...vergence.de>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ttusb-budget: make it depend on PCI

On Wednesday 12 November 2008, Andi Kleen wrote:
> Unless it really needs to use the 16MB DMA zone (which I doubt
> especially for USB devices) then it should not call either with a NULL
> device argument.

Yes, of course. It will need to pass &ttusb->dev.dev to dma_alloc_coherent.

	Arnd <><

---

Note to self: read code before commenting on it...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/