linux-kernel - Re: [PATCH 5/7] kprobes: Remove called

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <491AF801.3030302@redhat.com>
Date:	Wed, 12 Nov 2008 10:36:33 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	ananth@...ibm.com
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Jim Keniston <jkenisto@...ibm.com>,
	David Miller <davem@...emloft.net>,
	Rusty Russell <rusty@...tcorp.com.au>,
	LKML <linux-kernel@...r.kernel.org>,
	systemtap-ml <systemtap@...rces.redhat.com>
Subject: Re: [PATCH 5/7] kprobes: Remove called_from argument

Hi Ananth,

Ananth N Mavinakayanahalli wrote:
> 
> You also need the following to get this to compile, don't you?

Oops, Indeed.
Thank you very much!
Where I've lost this parts...?

> Signed-off-by: Ananth N Mavinakayanahalli <ananth@...ibm.com>

Acked-by: Masami Hiramatsu <mhiramat@...hat.com>

> 
> Index: linux-2.6.28-rc4/kernel/kprobes.c
> ===================================================================
> --- linux-2.6.28-rc4.orig/kernel/kprobes.c	2008-11-12 11:13:30.000000000 +0530
> +++ linux-2.6.28-rc4/kernel/kprobes.c	2008-11-12 12:18:44.000000000 +0530
> @@ -666,8 +666,6 @@
>  	 */
>  	probed_mod = __module_text_address((unsigned long) p->addr);
>  	if (probed_mod) {
> -		struct module *calling_mod;
> -		calling_mod = __module_text_address(called_from);
>  		/*
>  		 * We must hold a refcount of the probed module while updating
>  		 * its code to prohibit unexpected unloading.

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/