linux-kernel - Re: [PATCH] mac80211: add explicit padding in struct ieee80211_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1226509724.14186.14.camel@johannes.berg>
Date:	Wed, 12 Nov 2008 18:08:44 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	"John W. Linville" <linville@...driver.com>
Cc:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] mac80211: add explicit padding in struct
	ieee80211_tx_info

On Wed, 2008-11-12 at 10:05 -0500, John W. Linville wrote:
> Otherwise, the BUILD_BUG_ON calls in ieee80211_tx_info_clear_status can
> fail on some architectures.
> 
> Signed-off-by: John W. Linville <linville@...driver.com>
> ---
> Why do we have those BUILD_BUG_ON calls anyway?  Hmmm...

Because we actually use those offsets in places to clear things.

>  include/net/mac80211.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/net/mac80211.h b/include/net/mac80211.h
> index feb52cc..38302d6 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -333,6 +333,7 @@ struct ieee80211_tx_info {
>  	u8 antenna_sel_tx;
>  
>  	/* 2 byte hole */
> +	u8 pad[2];
>  
>  	union {
>  		struct {

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)