| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20081112180139.GH13263@ghostprotocols.net> Date: Wed, 12 Nov 2008 16:01:39 -0200 From: Arnaldo Carvalho de Melo <acme@...hat.com> To: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] markers: Add missing stdargs.h include, needed due to va_list usage Em Wed, Nov 12, 2008 at 12:21:47PM -0500, Mathieu Desnoyers escreveu: > * Arnaldo Carvalho de Melo (acme@...hat.com) wrote: > > diff --git a/include/linux/marker.h b/include/linux/marker.h > > index 889196c..6213b5e 100644 > > --- a/include/linux/marker.h > > +++ b/include/linux/marker.h > > @@ -12,6 +12,7 @@ > > * See the file COPYING for more details. > > */ > > > > +#include <stdarg.h> > > Hrm given it's already included in kernel.h for printk, I am not sure > it's required here ? Although it cannot hurt to add it explicitly. Well, its just that while writing code I noticed that if I included marker.h as the first include the compilation would fail. My impression was that if you use something, you should include its definition, not relying on the includes hell. > Mathieu > > > #include <linux/types.h> > > > > struct module; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists