linux-kernel - Re: [PATCH 2/2] x86: ia32_signal: remove unnecessary padding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <491B21BB.5080001@ct.jp.nec.com>
Date:	Wed, 12 Nov 2008 10:34:35 -0800
From:	Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] x86: ia32_signal: remove unnecessary padding

Andi Kleen wrote:
> Hiroshi Shimamoto <h-shimamoto@...jp.nec.com> writes:
> 
>> From: Hiroshi Shimamoto <h-shimamoto@...jp.nec.com>
>>
>> Impact: cleanup
> 
> Actually it's not a cleanup.
> 
>> Remove unnecessary paddings, this saves 4 bytes.
> 
> This might actually break code. The code is not actually used,
> but only kept around because some old gdb versions used this
> code as a marker for detecting signals.

I think, this cleanup doesn't change the code copied to user stack.
It removes additional 2 bytes from each struct, and these had not
been copied to user stack, because the structures were 10 bytes and
frame->retcode is 8 bytes.

Thanks,
Hiroshi Shimamoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/