linux-kernel - Re: [arch/x86/vdso/vdso32-syms.lds] Error 1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081112185617.4A1C71541FE@magilla.localdomain>
Date:	Wed, 12 Nov 2008 10:56:17 -0800 (PST)
From:	Roland McGrath <roland@...hat.com>
To:	Markus Trippelsdorf <markus@...ppelsdorf.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [arch/x86/vdso/vdso32-syms.lds] Error 1

Sorry for the delay, I've been offline.

> All of a sudden I get the following error when I build the kernel:

Suddenly when?  What changed to make this start happening?
Is it recent kernel sources?  If so, can you git-bisect to
which change did it?  If not, did something else change in
your build environment that made this problem appear?
Does it come or go with some .config change?

> --- -   2008-11-07 18:51:36.392997346 +0100
> +++ arch/x86/vdso/vdso32-int80-syms.lds 2008-11-07 18:51:36.283820343 +0100
> @@ -3,5 +3,3 @@
>  VDSO32_sigreturn = 0x0400;
>  VDSO32_vsyscall = 0x0420;
>  VDSO32_vsyscall_eh_frame_size = 0x040;
> -VDSO32_vsyscall = 0x0420;
> -VDSO32_vsyscall_eh_frame_size = 0x040;
> make[1]: *** [arch/x86/vdso/vdso32-syms.lds] Error 1
> make: *** [arch/x86/vdso] Error 2

That sure looks odd.  It looks like sort -u failed to uniquify those lines.

Can you try something like this:

> -	else rm -f $(@D)/.tmp_$(@F); exit 1; \
> +	else cat >&2 $(@D)/.tmp_$(@F); exit 1; \

and run make V=1 to see the full output on the failure?

> When I edit arch/x86/vdso/Makefile as follows,
> 
> diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
> index 4d6ef0a..8d93123 100644
> --- a/arch/x86/vdso/Makefile
> +++ b/arch/x86/vdso/Makefile
> @@ -107,7 +107,7 @@ define cmd_vdso32sym
>  		     else sed /VDSO32_SYSENTER_RETURN/d $(@D)/.tmp_$(@F) | \
>  			  diff -u - $H; fi &&) : ;\
>  	then mv -f $(@D)/.tmp_$(@F) $@; \
> -	else rm -f $(@D)/.tmp_$(@F); exit 1; \
> +	else mv -f $(@D)/.tmp_$(@F) $@; \
>  	fi
>  endef

This is ignoring the wrongly failing check, not fixing it.

> A least one other person has hit the same problem already:
> http://bugzilla.kernel.org/show_bug.cgi?id=11739

That report doesn't have a lot of information and doesn't show output that
looks the same as yours.  I'm not sure it's the same issue at all.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/