linux-kernel - next: 6a13378a5 (Don't allow KWorld radio...) is broken

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <491B3E90.5020307@gmail.com>
Date:	Wed, 12 Nov 2008 21:37:36 +0100
From:	Jiri Slaby <jirislaby@...il.com>
To:	Alexey Klimov <klimov.linux@...il.com>
CC:	Tobias Lorenz <tobias.lorenz@....net>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Jiri Kosina <jkosina@...e.cz>, linux-input@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: next: 6a13378a5 (Don't allow KWorld radio...) is broken

Hi guys,

The commit below is apparently wrong. Maybe you CCed HID maintainer, however
linux-input didn't get the message, or at least I can't find it anywhere.

There is a difference between hid_blacklist and hid_ignore_list. One forbids
generic hid driver to bind the device, while the other forces usbhid to release
the device and move hands away from it.

You picked up the former, which is wrong. I wonder if you were so lucky that you
didn't hit it. Care to send a fixup with proper CCs?

Thanks.

commit 6a13378a56ce06afca9db75f3d4e663fba5f0992
Author: Alexey Klimov <klimov.linux@...il.com>
Date:   Sun Oct 19 20:10:13 2008 -0300

    V4L/DVB (9337a): HID: Don't allow KWorld radio fm700 be handled by usb hid d
rivers

    This device is already handled by radio-si470x driver, and we
    therefore want usbhid to ignore it.

    Signed-off-by: Alexey Klimov <klimov.linux@...il.com>
    Acked-by: Tobias Lorenz <tobias.lorenz@....net>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@...hat.com>

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 1903e75..d3671b4 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1265,6 +1265,7 @@ static const struct hid_device_id hid_blacklist[] = {
        { HID_USB_DEVICE(USB_VENDOR_ID_EZKEY, USB_DEVICE_ID_BTC_8193) },
        { HID_USB_DEVICE(USB_VENDOR_ID_GENERIC_13BA, USB_DEVICE_ID_GENERIC_13BA_
KBD_MOUSE) },
        { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE)
},
+       { HID_USB_DEVICE(USB_VENDOR_ID_KWORLD, USB_DEVICE_ID_KWORLD_RADIO_FM700)
 },
        { HID_USB_DEVICE(USB_VENDOR_ID_GYRATION, USB_DEVICE_ID_GYRATION_REMOTE_2
) },
        { HID_USB_DEVICE(USB_VENDOR_ID_LABTEC, USB_DEVICE_ID_LABTEC_WIRELESS_KEY
BOARD) },
        { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_MX3000_RECEIVER)
},

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/