linux-kernel - Re: CONFIG_NUMA breaks hibernation on x86-32 with PAE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200811122257.50998.rjw@sisk.pl>
Date:	Wed, 12 Nov 2008 22:57:50 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Pavel Machek <pavel@...e.cz>
Cc:	Andi Kleen <andi@...stfloor.org>, Ingo Molnar <mingo@...e.hu>,
	kernel list <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: CONFIG_NUMA breaks hibernation on x86-32 with PAE

On Wednesday, 12 of November 2008, Pavel Machek wrote:
> 
> > > > > Well, interesting point would be just before this commit:
> > > > > 
> > > > > 
> > > > > commit 8357376d3df21b7d6f857931a57ac50da9c66e26 
> > > > > tree daf2c369e9b79d24c1666323b3ae75189e482a4a 
> > > > > parent bf73bae6ba0dc4bd4f1e570feb34a06b72725af6 
> > > > > author Rafael J. Wysocki <rjw@...k.pl> Wed, 06 Dec 2006 20:34:18 -0800 
> > > > > committer Linus Torvalds <torvalds@...dy.osdl.org> Thu, 07 Dec 2006
> > > > > 08:39:27 -0800 
> > > > > 
> > > > >     [PATCH] swsusp: Improve handling of highmem
> ...
> > > And it does not work with single highmem page when NUMA is set... I
> > > went through the highmem saving code, and it depends on highmem not
> > > changing from  under it (right?) and is generally quite tricky ('if
> > > they are both in highmem do this, else if one of them is do that, else
> > > do something else')
> > 
> > It actually is quite simple, if you know the idea.
> > 
> > > and it changes page protections on the fly, etc. 
> > 
> > No, it doesn't do that, at least for pages it hasn't allocated itself.  I don't
> > think it changes anything like page protections at all, though.
> 
> safe_copy_page() seems to call kernel_map_pages() on s_page... which
> is page from the system AFAICT...
> 
> > > I'm not saying the bug is in that code, but before that commit we had
> > > very stupid --- but very robust -- code. I'll try if that one works
> > > with config_numa, perhaps we can get some debug info that way.
> > 
> > if you can do that, it actually may be valuable information.
> 
> So far I know that software suspend depends on !PAE in that old
> version. If I only recalled why...

It didn't create the temporary page tables during resume, IIRC.

Anyway, I have a real fix for this bug, will post in a little while.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/