linux-kernel - Re: [PATCH] rtc: bunch of drivers: fix 'no irq' case handing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081111161728.8a0d73f1.akpm@linux-foundation.org>
Date:	Tue, 11 Nov 2008 16:17:28 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Anton Vorontsov <avorontsov@...mvista.com>
Cc:	a.zummo@...ertech.it, david-b@...bell.net,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: bunch of drivers: fix 'no irq' case handing

On Thu, 6 Nov 2008 20:41:11 +0300
Anton Vorontsov <avorontsov@...mvista.com> wrote:

> This patch fixes bunch of irq checking misuses.  Most drivers were getting
> irq via platform_get_irq(), which returns -ENXIO or r->start.  Platforms
> may specify r->start = 0 to emphasize 'no irq' case, and drivers should
> handle this correctly.
> 
> rtc-cmos.c is special.  It is using PNP and platform bindings.  Hopefully
> nobody is using PNP IRQ 0 for RTC.  So the changes should be safe.
> 
> rtc-sh.c is using platform_get_irq, but was storing a result into an
> unsigned type, then was checking for < 0.  This is fixed now.
> 
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>

Do we see any reason why this should be pushed into 2.6.28?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/