linux-kernel - Re: [PATCH 2/3] 8250: Oxford Semiconductor Devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081113095925.4a3fea5d@lxorguk.ukuu.org.uk>
Date:	Thu, 13 Nov 2008 09:59:25 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Andrey Panin <pazke@...pac.ru>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] 8250: Oxford Semiconductor Devices

> > +		number_uarts = ioread8(p + 4);
> > +		board->num_ports = number_uarts;
> 
> Why not just return number of ports here ?

That would leak mappings
> 
> > +		printk(KERN_DEBUG
> > +			"%d ports detected on Oxford PCI Express device\n",
> > +								number_uarts);
> 
> Is this printk really necessary ?

For the moment yes.

> WTF is this ? Why existing pci_serial_quirks[] infrastructure cannot be used here ?

Russell already fixed that and the change went upstream.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/