[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20081113120312.GA30307@oksana.dev.rtsoft.ru>
Date: Thu, 13 Nov 2008 15:03:12 +0300
From: Anton Vorontsov <avorontsov@...mvista.com>
To: Felipe Balbi <me@...ipebalbi.com>
Cc: linux-kernel@...r.kernel.org,
Felipe Balbi <felipe.balbi@...ia.com>,
Anton Vorontsov <cbou@...l.ru>,
David Woodhouse <dwmw2@...radead.org>,
Greg KH <greg@...ah.com>, Pierre Ossman <drzeus@...eus.cx>,
Richard Purdie <rpurdie@...ux.intel.com>
Subject: Re: [PATCH] led: simplify led_trigger_register_simple
On Thu, Nov 13, 2008 at 05:09:13AM +0200, Felipe Balbi wrote:
> From: Felipe Balbi <felipe.balbi@...ia.com>
>
> We can make led_trigger_register_simple by returning a
> struct led_trigger *, instead of passing a struct led_trigger **
> as a parameter and changing it inside the function.
>
> Cc: Anton Vorontsov <cbou@...l.ru>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Greg KH <greg@...ah.com>
> Cc: Pierre Ossman <drzeus@...eus.cx>
> Cc: Richard Purdie <rpurdie@...ux.intel.com>
> Signed-off-by: Felipe Balbi <felipe.balbi@...ia.com>
> ---
> Note that I could only test ide, power_supply and mmc changes with my laptop.
> The other changes weren't tested.
>
> drivers/leds/led-triggers.c | 25 ++++++++++++++---------
> drivers/leds/ledtrig-ide-disk.c | 6 ++++-
> drivers/mmc/core/host.c | 4 ++-
> drivers/mtd/nand/nand_base.c | 5 +++-
> drivers/power/power_supply_leds.c | 36 ++++++++++++++++++++++++++++------
For power supply bits:
Acked-by: Anton Vorontsov <cbouatmailru@...il.com>
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists