linux-kernel - [PATCH] leds: Fix locking for WM8350

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1226588269-17642-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Date:	Thu, 13 Nov 2008 14:57:49 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Richard Purdie <rpurdie@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: [PATCH] leds: Fix locking for WM8350

LED API functions aren't allowed to sleep so we can't take a lock when
setting the brightness of the LED.

Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
---

Sorry, I managed to drop this fix when moving the driver over to
mainline for submission.  I'll roll it into the original patch in any
future submissions.

 drivers/leds/leds-wm8350.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/leds/leds-wm8350.c b/drivers/leds/leds-wm8350.c
index f3e5af3..283625c 100644
--- a/drivers/leds/leds-wm8350.c
+++ b/drivers/leds/leds-wm8350.c
@@ -170,10 +170,7 @@ static void wm8350_led_set(struct led_classdev *led_cdev,
 {
 	struct wm8350_led *led = to_wm8350_led(led_cdev);
 
-	mutex_lock(&led->mutex);
 	led->value = value;
-	mutex_unlock(&led->mutex);
-
 	schedule_work(&led->work);
 }
 
-- 
1.5.6.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/