linux-kernel - Re: [PATCH] mtd: unify mtd partition/device registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20081114.005132.78730934.anemo@mba.ocn.ne.jp>
Date:	Fri, 14 Nov 2008 00:51:32 +0900 (JST)
From:	Atsushi Nemoto <anemo@....ocn.ne.jp>
To:	vapier.adi@...il.com
Cc:	vapier@...too.org, linux-mtd@...ts.infradead.org,
	dwmw2@...radead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mtd: unify mtd partition/device registration

On Thu, 13 Nov 2008 09:51:01 -0500, "Mike Frysinger" <vapier.adi@...il.com> wrote:
> > Automatic fallback to mtd_device in parse_mtd() is convenient but
> > somewhat unflexible...
> 
> we could just have it do it all the time.  i dont see a problem with
> exposing the entire block device the whole time ?  i know for the
> driver or two of mine, i'm fine with it.
> 
> ...
>        ret = parse_mtd_partitions(mtd, probe_types, &parts, 0);
>        if (ret > 0) {
>                ret = add_mtd_partitions(mtd, parts, ret);
>                kfree(parts);
>        } else if (nr_parts)
>                ret = add_mtd_partitions(mtd, parts, nr_parts);
>        if (ret)
>                return ret;
> #endif
> 
>        return add_mtd_device(mtd);

I'm OK with this.  But not sure all current mtd partition users.

Are you going to convert all parse_mtd_partitions() call?  Maybe some
people do not want to change /dev/mtd numbers...

---
Atsushi Nemoto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/