linux-kernel - Re: [PATCH] usbmon binary format reader loses synchronization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Nov 2008 14:46:36 -0700
From:	Pete Zaitcev <zaitcev@...hat.com>
To:	Ingo van Lil <inguin@....de>
Cc:	linux-kernel@...r.kernel.org, zaitcev@...hat.com
Subject: Re: [PATCH] usbmon binary format reader loses synchronization

On Thu, 13 Nov 2008 13:59:45 +0100, Ingo van Lil <inguin@....de> wrote:

> +++ b/drivers/usb/mon/mon_bin.c	2008-11-13 11:44:03.000000000 +0100
> @@ -681,7 +681,7 @@
>  	}
>  
>  	if (rp->b_read >= sizeof(struct mon_bin_hdr)) {
> -		step_len = min(nbytes, (size_t)ep->len_cap);
> +		step_len = min(nbytes, sizeof(struct mon_bin_hdr) + (size_t)ep->len_cap - rp->b_read);
>  		offset = rp->b_out + PKT_SIZE;

I cannot tell right away if this is the best fix, but I'll look
into this. Thanks a lot!

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/