linux-kernel - Re: [PATCH] sparse_irq aka dyn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20081113220503.GA15109@elte.hu>
Date:	Thu, 13 Nov 2008 23:05:03 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, tglx@...utronix.de,
	hpa@...or.com, linux-kernel@...r.kernel.org, travis@....com
Subject: Re: [PATCH] sparse_irq aka dyn_irq v13


* Yinghai Lu <yinghai@...nel.org> wrote:


> >> +     /*
> >> +      * We have to do the hash-walk again, to avoid races
> >> +      * with another CPU:
> >> +      */
> >> +     list_for_each_entry(desc, hash_head, hash_entry)
> >> +             if (desc->irq == irq)
> >> +                     goto out_unlock;

should be:

> >> +     list_for_each_entry(desc, hash_head, hash_entry) {
> >> +             if (desc->irq == irq)
> >> +                     goto out_unlock;
> >> +     }

and:

> >> +     desc = kzalloc_node(sizeof(*desc), GFP_KERNEL, node);
> >
> > Oh for gawd's sake.  PLEASE read Documentation/SubmitChecklist. 
> > Carefully.  We've already discussed this.
> >
> > You cannot do a GFP_KERNEL allocation under spin_lock_irqsave().

yes.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/