linux-kernel - Re: [patch 02/17] get_cycles() : x86 HAVE_GET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0811130814220.27005@anakin>
Date:	Thu, 13 Nov 2008 08:15:08 +0100 (CET)
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	akpm@...ux-foundation.org, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Steven Rostedt <rostedt@...dmis.org>,
	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>,
	Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-arch@...r.kernel.org
Subject: Re: [patch 02/17] get_cycles() : x86 HAVE_GET_CYCLES

On Wed, 12 Nov 2008, Mathieu Desnoyers wrote:
> --- linux.trees.git.orig/arch/x86/include/asm/tsc.h	2008-11-12 18:15:25.000000000 -0500
> +++ linux.trees.git/arch/x86/include/asm/tsc.h	2008-11-12 18:15:28.000000000 -0500
> @@ -56,6 +56,18 @@ extern void mark_tsc_unstable(char *reas
>  extern int unsynchronized_tsc(void);
>  int check_tsc_unstable(void);
>  
> +static inline cycles_t get_cycles_rate(void)
> +{
> +	if (check_tsc_unstable())
> +		return 0;
> +	return tsc_khz;
                   ^^^

The comment in Kconfig says:

| get_cycles_rate() : cycle counter rate, in HZ
                                             ^^

So what should it be? Hz or kHz?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/