lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 14 Nov 2008 14:25:01 +0100
From:	"Frédéric Weisbecker" <fweisbec@...il.com>
To:	"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	rostedt@...dmis.org, mingo@...e.hu, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] ftrace: Add debug_dump trace to dump binary data from kernel to userspace

2008/11/14 Frédéric Weisbecker <fweisbec@...il.com>:
> 2008/11/14 Aneesh Kumar K.V <aneesh.kumar@...ux.vnet.ibm.com>:
>> +static int
>> +trace_seq_putmem(struct trace_seq *s, void *mem, size_t len)
>> +{
>> +       if (len > ((PAGE_SIZE - 1) - s->len))
>> +               return 0;
>> +
>> +       memcpy(s->buffer + s->len, mem, len);
>> +       s->len += len;
>> +
>> +       return len;
>> +}
>
>
>
> I forgot to say that I like the idea of this tracer. That would be
> useful to dump some random datas from memory.
> But I would find it much more useful if I could choose whether the
> output is raw bytes or an hexadecimal drawing of the dump,
> pretty much like hexdump does. That's better to know where we are in
> the dump, and to have a directly human readable dump.
>
> Currently this is not yet possible to choose whether we want a kind of
> output or one other. Or perhaps by listen to the iter flags.
> I will probably send a patch to make a tracer able to support custom
> flags through the old-named iter_ctrl file.


Actually yes, what you could do is verifying whether the current
trace_flags is TRACE_ITER_HEX or
TRACE_ITER_BIN and format your output depending on which one is set....
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ